Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: we did not have a good chain of height: 100% divs #178

Merged
merged 2 commits into from
Jul 20, 2023
Merged

fix: we did not have a good chain of height: 100% divs #178

merged 2 commits into from
Jul 20, 2023

Conversation

maartenbreddels
Copy link
Contributor

@maartenbreddels
fix: autorouting should pick up modules that only define routes
2278600 
Instead of having a Page component, we should also just allow a user
to define a set of routes.
This is what we need for the /apps/scrolling example.
@maartenbreddels
fix: we did not have a good chain of height: 100% divs
cc9a071 
this did not enable users to add their own height: 100% elements
with scrollbars.
@maartenbreddels maartenbreddels marked this pull request as ready for review June 28, 2023 19:49
@maartenbreddels maartenbreddels merged commit 2f2ac7e into master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maartenbreddels